Hi,
Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically so new contributors (and experienced ones!) can fix basic issues without a human needing to point them out.
I added some brief instructions to [1] on how to run it locally, or you can read the jenkins output.
There are still a few code style rules that are disabled, [2] is tracking fixing those issues.
Please file any bugs or feature requests in the MediaWiki-CodeSniffer[3] project on Phabricator.
[1] https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer [2] https://phabricator.wikimedia.org/T102609 [3] https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/
-- Legoktm
foreach( $people_Involved as $person): $person->thank( ) ; endforeach ;
Il 27/09/2015 01:28, Legoktm ha scritto:
Hi,
Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically so new contributors (and experienced ones!) can fix basic issues without a human needing to point them out.
I added some brief instructions to [1] on how to run it locally, or you can read the jenkins output.
There are still a few code style rules that are disabled, [2] is tracking fixing those issues.
Please file any bugs or feature requests in the MediaWiki-CodeSniffer[3] project on Phabricator.
[1] https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer [2] https://phabricator.wikimedia.org/T102609 [3] https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/
-- Legoktm
Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
On Sun, Sep 27, 2015 at 2:20 AM, Ricordisamoa [email protected] wrote:
foreach( $people_Involved as $person): $person->thank( ) ; endforeach ;
:) Indeed!
Thank you Legoktm, this is very useful and fits very well in our efforts to improve our code review practices.
Il 27/09/2015 01:28, Legoktm ha scritto:
Hi,
Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically so new contributors (and experienced ones!) can fix basic issues without a human needing to point them out.
I added some brief instructions to [1] on how to run it locally, or you can read the jenkins output.
There are still a few code style rules that are disabled, [2] is tracking fixing those issues.
Please file any bugs or feature requests in the MediaWiki-CodeSniffer[3] project on Phabricator.
[1] https://www.mediawiki.org/wiki/Continuous_integration/PHP_CodeSniffer [2] https://phabricator.wikimedia.org/T102609 [3] https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/
-- Legoktm
Hi,
On 09/26/2015 04:28 PM, Legoktm wrote:
There are still a few code style rules that are disabled, [2] is tracking fixing those issues.
These have all been resolved, and all rules in the MediaWiki standard are now passing and voting \o/
[2] https://phabricator.wikimedia.org/T102609
-- Legoktm
If you're intrigued by all the code checking automation available, Extension:BoilerPlate [1] implements both the `npm test` and `composer test` entry points, and people have updated it to run jshint, jscs, banana-checker, jsonlint, php-parallel-lint, and now PHP CodeSniffer. Its README [2] explains how to get rolling. So if you start a new extension from BoilerPlate or copy over its files, your extension or skin benefits from the same code checks.
Then you can copy its Continuous Integration configuration [3] so that Jenkins run these tests on your extension or skin on each commit pushed to gerrit.wikimedia.org.
[1] https://www.mediawiki.org/wiki/Extension:BoilerPlate [2] https://gerrit.wikimedia.org/r/#/c/237058/4/README.md [3] https://gerrit.wikimedia.org/r/#/c/226680/
On Sat, Sep 26, 2015 at 4:28 PM, Legoktm [email protected] wrote:
Thanks to the hard work of a lot of different people, PHP CodeSniffer is now voting on all MediaWiki core patchsets! It checks for basic code style issues automatically